chore: Update valid permissions for organization repository role#3444
Open
w1mvy wants to merge 1 commit into
Open
chore: Update valid permissions for organization repository role#3444w1mvy wants to merge 1 commit into
w1mvy wants to merge 1 commit into
Conversation
|
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the change?
validRolePermissionsingithub/resource_github_organization_repository_role.gowas a snapshot of the GitHub repository fine-grained permissions API and had drifted from the upstream response. It rejected newer permissions (read_copilot_agent_settings,write_copilot_agent_settings,write_repository_agent_secrets,write_repository_agent_variables) at plan time viaCustomizeDiff, even though the GitHub API would accept them.apiVersion=2022-11-28, which is no longer the current version on the linked GitHub docs page.After the change?
validRolePermissions(kept alphabetically sorted) so configurations using them now pass validation.apiVersion=2026-03-10to match the current GitHub docs page forGET /orgs/{org}/repository-fine-grained-permissions.GET /orgs/{org}/repository-fine-grained-permissionsagainst a real org and diffing the returnednames against the existing slice; only additions were observed (no permissions removed upstream).Pull request checklist
Notes:
make generatedocsproduced no diff (the generated docs do not enumerate individual permissions).make fmt,make lint, andmake testall pass locally.Does this introduce a breaking change?